- To: perl-Math-Random-MT-Auto-owner@xxxxxxxxxxxxxxxxx, scm-commits@xxxxxxxxxxxxxxxxxxxxxxx
- Subject: [perl-Math-Random-MT-Auto] 6.17 bump
- From: Petr Pisar <ppisar@xxxxxxxxxxxxxxxxx>
- Date: Fri, 20 Jan 2012 13:02:57 +0000 (UTC)
- Delivered-to: Perl-devel@xxxxxxxxxxxxxxxxxxxxxxx
- Delivered-to: perl-math-random-mt-auto-owner@xxxxxxxxxxxxxxxxx
- Keywords: perl-Math-Random-MT-Auto
- Reply-to: Fedora perl development team <perl-devel@xxxxxxxxxxxxxxxxxxxxxxx>
commit 5bb26f4f1b4bb5780062c96be28bca173b5687ef
Author: Petr Písař <ppisar@xxxxxxxxxx>
Date: Thu Jan 19 17:38:13 2012 +0100
6.17 bump
.gitignore | 1 +
perl-Math-Random-MT-Auto.spec | 57 +++++++++++++++++++++++------------------
sources | 2 +-
3 files changed, 34 insertions(+), 26 deletions(-)
---
diff --git a/.gitignore b/.gitignore
index ff69bfe..04e0519 100644
--- a/.gitignore
+++ b/.gitignore
@@ -1,2 +1,3 @@
Math-Random-MT-Auto-6.14.tar.gz
/Math-Random-MT-Auto-6.16.tar.gz
+/Math-Random-MT-Auto-6.17.tar.gz
diff --git a/perl-Math-Random-MT-Auto.spec b/perl-Math-Random-MT-Auto.spec
index e127803..aa96040 100644
--- a/perl-Math-Random-MT-Auto.spec
+++ b/perl-Math-Random-MT-Auto.spec
@@ -1,47 +1,54 @@
Name: perl-Math-Random-MT-Auto
-Version: 6.16
-Release: 5%{?dist}
+Version: 6.17
+Release: 1%{?dist}
Summary: Auto-seeded Mersenne Twister PRNGs
License: BSD
Group: Development/Libraries
URL: http://search.cpan.org/dist/Math-Random-MT-Auto/
Source0: http://www.cpan.org/authors/id/J/JD/JDHEDDEN/Math-Random-MT-Auto-%{version}.tar.gz
-Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version))
+BuildRequires: perl(ExtUtils::MakeMaker)
+# Run-time
BuildRequires: perl(Carp)
BuildRequires: perl(Config)
-BuildRequires: perl(Data::Dumper)
-BuildRequires: perl(Exception::Class) >= 1.22
-BuildRequires: perl(ExtUtils::MakeMaker)
+BuildRequires: perl(Exception::Class) >= 1.32
BuildRequires: perl(Fcntl)
-BuildRequires: perl(LWP::UserAgent)
-BuildRequires: perl(Math::Random::MT::Auto::Range)
-BuildRequires: perl(Object::InsideOut) >= 2.06
-BuildRequires: perl(Scalar::Util) >= 1.18
+BuildRequires: perl(Object::InsideOut) >= 3.85
+BuildRequires: perl(Object::InsideOut::Util)
+BuildRequires: perl(Scalar::Util) >= 1.23
BuildRequires: perl(strict)
+BuildRequires: perl(XSLoader)
+# Tests only:
+BuildRequires: perl(Data::Dumper)
BuildRequires: perl(Test::More)
-BuildRequires: perl(Test::Pod)
-BuildRequires: perl(Test::Pod::Coverage)
-BuildRequires: perl(Test::Spelling)
BuildRequires: perl(threads)
BuildRequires: perl(threads::shared)
-BuildRequires: perl(warnings)
-BuildRequires: perl(XSLoader)
+# Optional tests
+BuildRequires: perl(LWP::UserAgent)
+Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version))
+Requires: perl(Exception::Class) >= 1.32
+Requires: perl(Fcntl)
+Requires: perl(Object::InsideOut) >= 3.85
+Requires: perl(Scalar::Util) >= 1.23
+
+%{?perl_default_filter}
+
+# Removed underpsecified dependencies
+%global __requires_exclude %{?__requires_exclude:%__requires_exclude|}^perl\\(Exception::Class\\)$
+%global __requires_exclude %__requires_exclude|^perl\\(Object::InsideOut\\)
+%global __requires_exclude %__requires_exclude|^perl\\(Scalar::Util\\)
%description
-The Mersenne Twister is a fast pseudorandom number generator (PRNG) that is
+The Mersenne Twister is a fast pseudo-random number generator (PRNG) that is
capable of providing large volumes (> 10^6004) of "high quality"
-pseudorandom data to applications that may exhaust available "truly" random
+pseudo-random data to applications that may exhaust available "truly" random
data sources or system-provided PRNGs such as rand.
-%{?filter_setup:
-%filter_from_requires /^perl(Object::InsideOut)$/d
-%{?perl_default_filter}
-}
%global __requires_exclude %{?__requires_exclude:%__requires_exclude|}perl\\(Object::InsideOut\\)$
%prep
%setup -q -n Math-Random-MT-Auto-%{version}
+chmod -x examples/*
%build
%{__perl} Makefile.PL INSTALLDIRS=vendor OPTIMIZE="$RPM_OPT_FLAGS"
@@ -49,24 +56,24 @@ make %{?_smp_mflags}
%install
make pure_install DESTDIR=$RPM_BUILD_ROOT
-
find $RPM_BUILD_ROOT -type f -name .packlist -exec rm -f {} \;
find $RPM_BUILD_ROOT -type f -name '*.bs' -size 0 -exec rm -f {} \;
find $RPM_BUILD_ROOT -depth -type d -exec rmdir {} 2>/dev/null \;
-
%{_fixperms} $RPM_BUILD_ROOT/*
%check
make test
%files
-%defattr(-,root,root,-)
-%doc Changes README
+%doc Changes README examples
%{perl_vendorarch}/auto/*
%{perl_vendorarch}/Math*
%{_mandir}/man3/*
%changelog
+* Thu Jan 19 2012 Petr Pisar <ppisar@xxxxxxxxxx> - 6.17-1
+- 6.17 bump
+
* Fri Jan 13 2012 Fedora Release Engineering <rel-eng@xxxxxxxxxxxxxxxxxxxxxxx> - 6.16-5
- Rebuilt for https://fedoraproject.org/wiki/Fedora_17_Mass_Rebuild
diff --git a/sources b/sources
index d5e89bc..27ab23c 100644
--- a/sources
+++ b/sources
@@ -1 +1 @@
-602470f808dbac3f68b373ed1c2be16a Math-Random-MT-Auto-6.16.tar.gz
+9c1680eec2d1d5b6cbb4cce48f7c2062 Math-Random-MT-Auto-6.17.tar.gz
--
Fedora Extras Perl SIG
http://www.fedoraproject.org/wiki/Extras/SIGs/Perl
perl-devel mailing list
perl-devel@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/perl-devel
- Prev by Date:
Re: Broken dependencies: perl-Bot-BasicBot
- Next by Date:
[Bug 781396] perl-Math-Random-MT-Auto-6.17 is available
- Previous by thread:
[Bug 783426] New: perl-Gtk2-1.242 is available
- Next by thread:
[perl-Business-ISBN-Data] Spec clean-up
- Index(es):
[Fedora Announce]
[Fedora Kernel]
[Fedora Testing]
[Fedora Legacy Announce]
[Home]
[Fedora Tools]
[Fedora PHP Devel]
[Kernel List]
[Fedora Legacy]
[Fedora Maintainers]
[Fedora Maintainers]
[Fedora Desktop]
[PAM]
[Red Hat Development]
[Big List of Linux Books]
[Gimp]
[Yosemite News]
[Bug 759757] Review Request: perl-Encode-EUCJPASCII - EucJP-ascii - An eucJP-open mapping
- To: package-review@xxxxxxxxxxxxxxxxxxxxxxx
- Subject: [Bug 759757] Review Request: perl-Encode-EUCJPASCII - EucJP-ascii - An eucJP-open mapping
- From: bugzilla@xxxxxxxxxx
- Date: Fri, 6 Jan 2012 04:19:40 -0500
- Auto-submitted: auto-generated
- Delivered-to: package-review@xxxxxxxxxxxxxxxxxxxxxxx
- In-reply-to: <bug-759757-308966@bugzilla.redhat.com>
- References: <bug-759757-308966@bugzilla.redhat.com>
- Reply-to: package-review@xxxxxxxxxxxxxxxxxxxxxxx
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=759757
Petr Pisar <ppisar@xxxxxxxxxx> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flag|fedora-review? |fedora-review+
--- Comment #3 from Petr Pisar <ppisar@xxxxxxxxxx> 2012-01-06 04:19:39 EST ---
SPEC file changes:
--- perl-Encode-EUCJPASCII.spec 2011-11-29 11:16:42.000000000 +0100
+++ perl-Encode-EUCJPASCII.spec.1 2012-01-05 17:19:24.000000000 +0100
@@ -1,6 +1,6 @@
Name: perl-Encode-EUCJPASCII
Version: 0.03
-Release: 1%{?dist}
+Release: 2%{?dist}
Summary: EucJP-ascii - An eucJP-open mapping
License: GPL+ or Artistic
Group: Development/Libraries
@@ -10,6 +10,12 @@
BuildRequires: perl(ExtUtils::MakeMaker)
BuildRequires: perl(Test::More)
BuildRequires: perl(Test::Pod)
+BuildRequires: perl(File::Spec)
+BuildRequires: perl(Encode)
+BuildRequires: perl(XSLoader)
+BuildRequires: perl(base)
+BuildRequires: perl(Encode::CJKConstants)
+BuildRequires: perl(Encode::JP::JIS7)
Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo
$version))
%{?perl_default_filter}
@@ -22,17 +28,16 @@
%setup -q -n Encode-EUCJPASCII-%{version}
%build
-%{__perl} Makefile.PL INSTALLDIRS=vendor
+%{__perl} Makefile.PL INSTALLDIRS=vendor OPTIMIZE="$RPM_OPT_FLAGS"
make %{?_smp_mflags}
%install
rm -rf $RPM_BUILD_ROOT
-
-make pure_install PERL_INSTALL_ROOT=$RPM_BUILD_ROOT
-
-find $RPM_BUILD_ROOT -type f -name .packlist -exec rm -f {} \;
-find $RPM_BUILD_ROOT -depth -type d -exec rmdir {} 2>/dev/null \;
-
+make pure_install DESTDIR=$RPM_BUILD_ROOT
+find $RPM_BUILD_ROOT -type f -name .packlist -exec rm -f {} ';'
+# Remove the next line from noarch packages (unneeded)
+find $RPM_BUILD_ROOT -type f -name '*.bs' -a -size 0 -exec rm -f {} ';'
+find $RPM_BUILD_ROOT -depth -type d -exec rmdir {} 2>/dev/null ';'
%{_fixperms} $RPM_BUILD_ROOT/*
%check
@@ -45,7 +50,12 @@
%defattr(-,root,root,-)
%doc Changes README
%{perl_vendorarch}/*
+%exclude %dir %{perl_vendorarch}/auto/
%changelog
+* Thu Jan 05 2012 Xavier Bachelot <xavier@xxxxxxxxxxxx> 0.03-2
+- Follow the rpmdevtools perl spec template to fix packaging bugs.
+- Add missing BuildRequires.
+
* Tue Nov 29 2011 Xavier Bachelot <xavier@xxxxxxxxxxxx> 0.03-1
- Initial Fedora release.
> > TODO: Remove useless BuildRoot definition, it's cleaning in %install
> > section, and whole %clean section. They are not needed anymore.
> > TODO: Remove useless %defattr from %files section.
> Needed for EPEL5, so I'd rather keep them.
Ok.
> > TODO: Build-require perl(Encode) for tests (EUCJPASCII.pm:6)
> > TODO: Build-require perl(XSLoader) for tests (EUCJPASCII.pm:7)
> > TODO: Build-require perl(base) for tests (EUCJPASCII.pm:18)
> > TODO: Build-require perl(Encode::CJKConstants) for tests (EUCJPASCII.pm:23)
> > TODO: Build-require perl(Encode::JP::JIS7) for tests (EUCJPASCII.pm:23)
> >
> Added.
> > FIX: Build-require perl(File::Spec) (Makefile.PL:18)
> Added.
+BuildRequires: perl(File::Spec)
+BuildRequires: perl(Encode)
+BuildRequires: perl(XSLoader)
+BuildRequires: perl(base)
+BuildRequires: perl(Encode::CJKConstants)
+BuildRequires: perl(Encode::JP::JIS7)
Ok.
> > FIX: Remove empty *.bs files. (These empty bootstrap files for DynaLoader are
> > useless.)
> Done. The spec is now following more closely the perl spec template, while the
> previous version was generated with cpanspec.
+find $RPM_BUILD_ROOT -type f -name '*.bs' -a -size 0 -exec rm -f {} ';'
Ok.
> I've compared the build log from both the older spec and the newer with the
> BuildRequires added, but I don't see a difference, so I'm a bit puzzled... Are
> the BRs really needed ?
The Perl modules are used directly by this code, so you need to build-require
them directly too. You cannot assume a module keeps in the the same RPM package
forever (e.g. the Encode is currently part of perl, but If someone decides to
sub-package it into perl-Encode or even dual-live it as packe sourced from
CPAN, this will not be true anymore) or a module keeps available through
indirect dependency (like File::Spec packaged as perl-PathTools).
$ rpmlint perl-Encode-EUCJPASCII.spec
../SRPMS/perl-Encode-EUCJPASCII-0.03-2.fc17.src.rpm
../RPMS/x86_64/perl-Encode-EUCJPASCII-*
perl-Encode-EUCJPASCII.src: W: spelling-error Summary(en_US) eucJP -> eggcup,
equip, uncap
perl-Encode-EUCJPASCII.src: W: spelling-error %description -l en_US eucJP ->
eggcup, equip, uncap
perl-Encode-EUCJPASCII.src: W: spelling-error %description -l en_US ascii ->
ASCII, ASCIIs, As
perl-Encode-EUCJPASCII.x86_64: W: spelling-error Summary(en_US) eucJP ->
eggcup, equip, uncap
perl-Encode-EUCJPASCII.x86_64: W: spelling-error %description -l en_US eucJP ->
eggcup, equip, uncap
perl-Encode-EUCJPASCII.x86_64: W: spelling-error %description -l en_US ascii ->
ASCII, ASCIIs, As
3 packages and 1 specfiles checked; 0 errors, 6 warnings.
rpmlint is Ok.
$ rpm -q -lv -p ../RPMS/x86_64/perl-Encode-EUCJPASCII-0.03-2.fc17.x86_64.rpm
drwxr-xr-x 2 root root 0 Jan 6 09:57
/usr/lib64/perl5/vendor_perl/Encode
-rw-r--r-- 1 root root 5662 Oct 19 2009
/usr/lib64/perl5/vendor_perl/Encode/EUCJPASCII.pm
drwxr-xr-x 2 root root 0 Jan 6 09:57
/usr/lib64/perl5/vendor_perl/auto/Encode
drwxr-xr-x 2 root root 0 Jan 6 09:57
/usr/lib64/perl5/vendor_perl/auto/Encode/EUCJPASCII
-rwxr-xr-x 1 root root 759824 Jan 6 09:57
/usr/lib64/perl5/vendor_perl/auto/Encode/EUCJPASCII/EUCJPASCII.so
drwxr-xr-x 2 root root 0 Jan 6 09:57
/usr/share/doc/perl-Encode-EUCJPASCII-0.03
-rw-r--r-- 1 root root 569 Oct 19 2009
/usr/share/doc/perl-Encode-EUCJPASCII-0.03/Changes
-rw-r--r-- 1 root root 496 Oct 19 2009
/usr/share/doc/perl-Encode-EUCJPASCII-0.03/README
File permissions and layout is Ok.
Package builds in F17
(http://koji.fedoraproject.org/koji/taskinfo?taskID=3624174). Ok.
Resolution: Package APPROVED.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review
- References:
- [Bug 759757] New: Review Request: perl-Encode-EUCJPASCII - EucJP-ascii - An eucJP-open mapping
- Prev by Date:
[Bug 771851] Review Request: python-ladon - Multiprotocol approach to creating a webservice
- Next by Date:
[Bug 771171] Review Request: django-tastypie - A webservice API framework for Django
- Previous by thread:
[Bug 759757] Review Request: perl-Encode-EUCJPASCII - EucJP-ascii - An eucJP-open mapping
- Next by thread:
[Bug 759757] Review Request: perl-Encode-EUCJPASCII - EucJP-ascii - An eucJP-open mapping
- Index(es):
[Fedora Legacy]
[Fedora Desktop]
[Fedora SELinux]
[Yosemite News]
[Yosemite Photos]
[KDE Users]
[Fedora Tools]
Read more ...
